Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mark customer_id as optional in api gateway api key #38724

Conversation

stefanfreitag
Copy link
Contributor

Description

In the documentation the attribute customer_id is marked as Required, but actually it is Optional. A link to the relevant source code has been provided in the References section.

Relations

Closes #38697

References

Output from Acceptance Testing

Not applicable. Only documentation is updated.

@stefanfreitag stefanfreitag requested a review from a team as a code owner August 7, 2024 06:36
Copy link

github-actions bot commented Aug 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. needs-triage Waiting for first response or review from a maintainer. labels Aug 7, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 7, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@stefanfreitag Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit aeb2a45 into hashicorp:main Aug 7, 2024
29 checks passed
@github-actions github-actions bot added this to the v5.62.0 milestone Aug 7, 2024
Copy link

github-actions bot commented Aug 9, 2024

This functionality has been released in v5.62.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2024
@stefanfreitag stefanfreitag deleted the d-aws_api_gateway_api_key-fix-customer-id branch October 8, 2024 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: aws_api_gateway_api_key - customer_id says it's required, when it isn't.
3 participants